Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the logo clickable #158

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Conversation

shubhamku044
Copy link
Contributor

No description provided.

@shubhamku044
Copy link
Contributor Author

#157

@starsep
Copy link
Member

starsep commented Aug 20, 2023

Thanks for your first contribution!

Unfortunately adding link in such a simple way changes how navbar is rendered

Before
image
After
image

@Zaczero
Copy link
Member

Zaczero commented Aug 21, 2023

Adding a simple display:flex CSS fixes the display.

image

@shubhamku044
Copy link
Contributor Author

Ok will do this. Actually I was not able to run the application locally. I tried both the ways, by running it in docker and by running directly on my machine. But both didn't worked out for me. So I didn't saw something broke after adding the anchor tag.

@Zaczero
Copy link
Member

Zaczero commented Aug 21, 2023

@shubhamku044
https://github.com/openstreetmap-polska/openaedmap-frontend#local-environment
Those instructions worked for me last time

@ttomasz
Copy link
Contributor

ttomasz commented Sep 17, 2023

I changed Navbar.Item renderAs="div" to Navbar.Item renderAs="a" href... and it seems to maintain formatting.

I tested it running from Github Codespace which is another option to open the project.

@ttomasz ttomasz merged commit 6035011 into openstreetmap-polska:dev Sep 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants